super_errors: run fixtures in parallel#8430
Open
JonoPrest wants to merge 2 commits into
Open
Conversation
Each fixture spawns a `bsc` process and the previous `for ... await` loop ran them sequentially, so wall time scaled linearly with fixture count. Replace with a fixed-size worker pool (`os.availableParallelism()` workers) and sort the fixture list for deterministic failure output. Locally on 264 fixtures this cuts the suite from ~2.2s to ~0.9s (~2.4x). The original 2019 implementation was also parallel; the sequential loop was a side-effect of the ESM/async-await refactor in rescript-lang#6899, which explicitly noted it wasn't refactoring tests.
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each fixture spawns a
bscprocess and the previousfor ... awaitloop ran them sequentially, so wall time scaled linearly with fixture count. Replace with a fixed-size worker pool (os.availableParallelism()workers) and sort the fixture list for deterministic failure output.Locally on 264 fixtures this cuts the suite from ~2.2s to ~0.9s (~2.4x). The original 2019 implementation was also parallel; the sequential loop was a side-effect of the ESM/async-await refactor in #6899, which explicitly noted it wasn't refactoring tests.